The Evolution of Code Review Feedback: Juniors vs. Seniors

Description

A four-quadrant meme using Wojak characters to contrast the communication styles of junior and senior developers during code reviews. The top half, labeled 'Junior Devs,' shows a developer hiding a crying face behind a smug mask, stating, 'Your code breaks SOLID and code style best practices.' The recipient, a crying Wojak, retorts defensively, 'No! You don't understand!'. This depicts a pedantic, emotionally charged exchange common among less experienced engineers. The bottom half, labeled 'Senior Devs,' features two calm, bearded 'Chad' Wojak characters. One states bluntly, 'Your code is shit.' The other simply replies, 'I know.' This illustrates the pragmatic, direct, and ego-free communication that often develops with experience, where both parties understand the real-world constraints and imperfections of software development

Common Tags

JuniorVsSenior CodeReview DeveloperHumor CodeQuality CodingFrustration RelatableDevExperience CodingCulture

Comments

Anonymous ★ Top Pick A junior's code review is an essay arguing about SOLID principles. A senior's code review is just the link to the new ticket in the tech debt epic

Anonymous ★ Top Pick

A junior's code review is an essay arguing about SOLID principles. A senior's code review is just the link to the new ticket in the tech debt epic
Anonymous

After two decades of code reviews I’ve reduced SOLID to one rule: the Single Liability Principle - whoever hits Merge owns the 3 AM pager
Anonymous

The real senior developer evolution isn't learning to write better code - it's developing the emotional detachment to watch your carefully crafted abstractions get called 'shit' in a PR comment and responding with 'fair point, let me refactor that' instead of writing a 3-page defensive essay about why your factory factory pattern was actually genius
Anonymous

The real senior move isn't writing perfect code - it's having the battle scars to know that 'shit code that ships' beats 'perfect code in your head' every time. We've all written that 3am hotfix that violates every SOLID principle but saves the quarter. The junior's defending their pristine architecture while the senior's already moved on to the next fire, knowing that code quality is a spectrum and shipping is binary
Anonymous

After 15 years, code review quietly rebrands to risk review - yes it violates SOLID, but touching it violates the SLO, the budget, and our weekend
Anonymous

Junior code review: “This violates SOLID.” Senior code review: “Touching it violates SLOs.” Architecture is choosing which acronym you’re willing to break this quarter
Anonymous

Juniors code SOLID; seniors know it'll be single-line prod fixes at 3AM
idr 5y

fuck SOLID/DDD/whatever, never helped and never will
1. Deleted Account 5y
  
  whats ddd
  
  idr 5y
  
  you know what i will answer with
  
  Deleted Account 5y
  
  DICK DICK DICK
  
  idr 5y
  
  no i meant google anyway my point is, if you cannot come up with a good design using the thing called reasoning, no paradigm will help you
  
  Deleted Account 5y
  
  oh, you meant google...
  
  Deleted Account 5y
  
  well ofc, tho you can still help the compiler if you write the code in a specific way
  
  idr 5y
  
  compiler? it doesn't care what your code does and how it's structered while it's up to the compiler and language specification
  
  Deleted Account 5y
  
  well, if it's an optimizing compiler, it kinda does, if you write code that's hinting the compiler at what you actally mean (eg using fold instead of plain for to accumulate a range of vals), it will optimize more
  
  idr 5y
  
  well yes obviously, but no paradigm aims to "hint the compiler how to optimize something". most paradigms aim to make the code, apparently, easier to maintain and read, tho on my experience in some cases they even make it worse. some oop programmers would go out of their way to write a singleton class instead of just writing a function, over-worrying about parts of code being reusable even though they are used only in one place but they abstract it into another function/class anyway
  
  Deleted Account 5y
  
  btw can we talk about how singleton is literally hitler
  
  Deleted Account 5y
  
  worst (p)oop antipattern
  
  @RiedleroD 5y
  
  idk I like singletons if used correctly
  
  Deleted Account 5y
  
  std::cin and std::cout in c++ are not singletons
  
  @RiedleroD 5y
  
  I was talking about singletons in Python
  
  Deleted Account 5y
  
  oh, python doesn't do oop that much
  
  @RiedleroD 5y
  
  literally everything in pytohn is an object
  
  Deleted Account 5y
  
  well yes, there aren't classes tho, like java clsses
  
  @RiedleroD 5y
  
  Yes there are? Not exactly the same, but there are classes.
  
  Deleted Account 5y
  
  well, not exactly the same
  
  @RiedleroD 5y
  
  that's what I said
  
  Deleted Account 5y
  
  yes
  
  idr 5y
  
  he probably means that oop in python is not mandatory unlike java
  
  @RiedleroD 5y
  
  which should be the default imo
  
  Deleted Account 5y
  
  this too
  
  @nuntikov 5y
  
  How about functional java...
  
  @RiedleroD 5y
  
  Java 18 be like
  
  Deleted Account 5y
  
  it sounds like c++29
  
  Deleted Account 5y
  
  oh i remember the boost.blockchain talk
  
  @RiedleroD 5y
  
  I don't
  
  Deleted Account 5y
  
  https://www.youtube.com/watch?v=tucdEnV4KYA
  
  Deleted Account 5y
  
  i like how he goes: you may be confused by this forward slash on the last line, it represents arithmetic division
  
  @nuntikov 5y
  
  C++29? What?
  
  idr 5y
  
  well every major framework is not
  
  idr 5y
  
  could you define "correctly"?
  
  @RiedleroD 5y
  
  no. I can't. Sorry.