Skip to content
DevMeme
1695 of 7590
CodeReviews Post #1891 · source on Telegram

Sliding my questionable commit to the senior dev with a smile

Description

Three - panel anime-style meme. Panel 1 shows a smiling child reaching toward an empty wooden tray on a counter. Panel 2 is identical, but the tray now has bold white text reading "Shit code." Panel 3 pulls back to show the child (head captioned "Me") pushing the tray through a small service window while saying "Review please"; on the opposite side a taller character (captioned "Senior Dev") stands ready to receive it. The humor comes from a junior engineer cheerfully submitting obviously low-quality code for peer review, highlighting the self-deprecating anxiety many developers feel during code-review cycles and the quality gatekeepers role of senior engineers

Comments

6
Anonymous ★ Top Pick Junior’s PR title: “Quick null-check.” Diff: 1,347 lines, new global singleton, and a circular dependency that turns the service graph into a Klein bottle - then the comment: “Mind giving this a speedy LGTM? Prod’s blocked.”
  1. Anonymous ★ Top Pick

    Junior’s PR title: “Quick null-check.” Diff: 1,347 lines, new global singleton, and a circular dependency that turns the service graph into a Klein bottle - then the comment: “Mind giving this a speedy LGTM? Prod’s blocked.”

  2. Anonymous

    The real senior dev move is knowing that 'shit code' that works and ships is infinitely more valuable than perfect code stuck in an endless refactoring loop - we've all been there, pushing that MVP with a //TODO: refactor this entire module comment

  3. Anonymous

    The real tragedy isn't the shit code - it's that the senior dev knows exactly what's in that PR before even opening it, because they wrote the same garbage 15 years ago. They'll approve it anyway with 'LGTM, but let's refactor this in Q3' knowing full well Q3 is when that code becomes production-critical legacy that nobody dares touch

  4. Anonymous

    When 'simple refactor' means nesting 17 ternaries in a 2k-line god function that hallucinates on leap years

  5. Anonymous

    Me: Review please. Senior dev: Rename "shit code" to "legacy", hide it behind a feature flag, add metrics - congrats, it's now architecture

  6. Anonymous

    Senior dev translation layer: 'review please' => 1,200-line diff, 0 tests, cyclic dependencies, and a 'minor fix' title - an expedited refactor disguised as feedback

Use J and K for navigation