Skip to content
DevMeme
2158 of 7590
CodeReviews Post #2409 · source on Telegram

When the Merge Request is a Dumpster Fire

Description

A screenshot of a GitLab merge request page in dark mode. The title of the merge request is 'Add widget controller'. It shows 5 commits, 89 additions, and 25 deletions. The merge request requires 2 more approvals and is 2 commits behind the target 'master' branch. A comment from the developer, 'A Programmer' with the handle '@dave', simply says 'this is fine'. The 'this is fine' comment is a direct reference to the popular 'This is Fine' dog meme, where a dog sits calmly in a room engulfed in flames. The joke is that the developer is acknowledging the chaotic or problematic state of their own large merge request with a sense of ironic detachment and gallows humor, a feeling many senior engineers recognize when pushing complex or contentious changes that are destined for a difficult code review

Comments

14
Anonymous ★ Top Pick A merge request with 89 changes is less of a 'request' and more of a 'hostage situation'. The 'this is fine' is just the developer Stockholm syndrome talking
  1. Anonymous ★ Top Pick

    A merge request with 89 changes is less of a 'request' and more of a 'hostage situation'. The 'this is fine' is just the developer Stockholm syndrome talking

  2. Anonymous

    The merge view looks like /dev/urandom got symlinked to main.css, but hey - two approvals, so “definition of done” apparently includes undefined behavior

  3. Anonymous

    After 99 commits and 25 changes, this PR has achieved what every senior engineer fears most: it's become sentient enough to generate its own scope creep through review comments alone

  4. Anonymous

    When your PR has been open so long that the code review interface starts looking like the Matrix - 89 commits, 25 changed files, still waiting for 2 approvals. At least 'A Programmer' thinks 'this is fine' while the digital rain of technical debt cascades around them. Classic case of when the merge conflict becomes an existential crisis: do you take the red pill and rebase, or the blue pill and force push?

  5. Anonymous

    GitLab: 'Merge ready!' Fine print: 'Via CLI, because UIs are for juniors and on-call is forever.'

  6. Anonymous

    PR title: “Add widget controller.” GitLab UI: raining glyphs. Translation: you didn’t add a controller - you shipped a fragment shader. Needs two approvals: the architect and your GPU

  7. Anonymous

    Nothing says enterprise maturity like a merge request UI rendered as VRAM confetti while the approvals gate still blocks the merge - reliability implemented at exactly the wrong layer

  8. @GLXBX 5y

    Wtf

  9. @fortrest 5y

    HE COMES

    1. @lord_nani 5y

      explain?

      1. @fortrest 5y

        Just google it

  10. @fortrest 5y

    Zalgo!

  11. @noryouneitherme 5y

    ZALGOOOOOOOOOO

  12. @janeoa 5y

    Hehehehe

Use J and K for navigation