CodeReviews
Post #4094 · source on Telegram
Pull Request Feedback So Vague It’s Like Warning Water About Being Wet
Description
The meme has a white top banner with the black text “when pull request comment is "code change" be like...”. Below, a photograph shows a bright-blue tiled swimming pool; in the middle of the deep water floats a yellow plastic caution sign that reads “CAUTION WET FLOOR” with the slipping-person icon. The sign, normally meant for a hallway, is uselessly warning the obviously wet pool, mirroring how an unhelpful pull-request comment saying merely “code change” provides no actionable information. The image humorously highlights pain points around code review communication, vague feedback, and developer frustration with uninformative PR comments
More like this
More like this in CodeReviews →
Use J and K for navigation
Comments
10Comment deleted
“Code change” as PR feedback is the wet-floor sign in the pool - 100 % correct, 0 % helpful, yet somehow it still clears the “two-reviewer” gate
After 15 years of reviewing code, the most valuable PR comment I've received was 'LGTM' - at least it didn't pretend to add value while wasting everyone's time like those 'consider using more descriptive variable names' comments on a method called calculateTotalPriceIncludingTaxAndShippingForInternationalOrdersWithDiscounts()
The reviewer left 'code change' on the PR, marked it as blocking, and went on PTO - the most thorough review the team has seen all quarter
Ah yes, the classic "just a small code change" comment that actually means "please refactor this entire module, update the architecture, migrate the database schema, and oh - could you also add comprehensive test coverage while you're at it?" It's the engineering equivalent of someone putting a wet floor sign in a swimming pool - technically accurate, but spectacularly missing the point. Senior engineers know this dance well: the more innocuous the PR comment sounds, the more architectural debt you're about to uncover. It's not a code review; it's an archaeological expedition disguised as a suggestion
"Code change" in a PR description is the wet floor sign floating in a pool: technically correct, useless for blast radius or reviewer sanity
Our two-approver policy devolved into two comments - “code change” and “LGTM” - the wet‑floor sign we toss into the data lake
'Code change' PR feedback: as insightful as spotting a race condition and noting 'timing issue' - thanks for the newsletter update
my friends call all of their commits like "ok" and "fix"... Comment deleted
upd😭 Comment deleted
As long as you squash them upon pr merge and then give a meaningful name to squash commit, it might be okay Comment deleted