Skip to content
DevMeme
72 of 7590
When Code Review Needs Typography
CodeReviews Post #97 · source on Telegram

When Code Review Needs Typography

Description

The image shows a cropped pull-request diff with green added lines and an inline review thread over the code. The visible code includes a loop like `for (let j=0; j<pointsToFilter.length; j++) {`, a following condition that appears to use a visually ambiguous `i` or `j`, and a later added `continue;`; the review box shows blurred usernames, "9 hours ago", "a minute ago", a comment reading roughly "i == i.", a reply resembling "(j == j)" with an arrow, and a "Reply..." field. The joke is about code review degenerating into a glyph-identification exercise when short variable names, small screenshots, and similar characters collide. It is less about algorithmic correctness than the maintainability cost of making reviewers reverse-engineer typography.

Categories

CodeReviews CodeQuality Languages Bugs

Common Tags

CodeReview CodeReviewPainPoints CodeReadability VariableNaming MonospaceFonts PullRequest CodeQuality NamingConventions Javascript DeveloperHumor

Comments

1
Anonymous ★ Top Pick A one-letter variable saves two keystrokes and spends them later with compound interest in review latency.
  1. Anonymous ★ Top Pick

    A one-letter variable saves two keystrokes and spends them later with compound interest in review latency.

More like this

More like this in CodeReviews →
CodeReviews CodeReview CodeReviewPainPoints
We Used to Review Every Line Before Production

We Used to Review Every Line Before Production

CodeReviews
Uncle Bob Won't Read His Agents' Code

Uncle Bob Won't Read His Agents' Code

AI ML
Senior Dev Takes Fire So Future Maintainers Can Sleep

Senior Dev Takes Fire So Future Maintainers Can Sleep

CodeReviews
Use J and K for navigation