Skip to content
DevMeme
728 of 7590
CodeReviews Post #826 · source on Telegram

The Perils of Code Review Scope Creep

Description

This image uses the popular 'Woman Yelling at a Cat' meme format to illustrate a common frustration in software development. The meme is a two-panel image. On the left, a distraught woman (Taylor Armstrong) is yelling and pointing, with the caption 'Senior Engineer: fix this code before I approve the merge'. On the right, a confused-looking white cat (Smudge the Cat) sits at a dinner table with a plate of salad, captioned 'Me: that's not even my code'. The meme humorously captures a frequent code review scenario where a developer submits a pull request for a specific change, but the reviewing senior engineer identifies unrelated, pre-existing issues in the same file or module. The senior then blocks the merge, demanding the developer fix this 'technical debt' they didn't create. This situation, often referred to as scope creep, places the developer in the awkward position of having to either take on extra work or argue about the scope of their task, perfectly reflected by the cat's bewildered and defensive expression

Comments

7
Anonymous ★ Top Pick The 'You Touched It Last' rule of code ownership is the enterprise version of musical chairs, but the last one standing has to refactor a 2000-line function with no tests
  1. Anonymous ★ Top Pick

    The 'You Touched It Last' rule of code ownership is the enterprise version of musical chairs, but the last one standing has to refactor a 2000-line function with no tests

  2. Anonymous

    At my shop, git has a new blame mode: “last-person-to-open-the-PR,” so tweaking one import makes you legal guardian of every 2009 XML/SOAP hairball that file ever touched

  3. Anonymous

    The senior engineer who can't read git blame is the same one who insists on squashing commits because "clean history" while simultaneously destroying all evidence of who actually wrote what

  4. Anonymous

    The real tragedy here isn't being asked to fix someone else's code - it's that 'git blame' will forever show YOUR name on those lines after the refactor, making you the historical scapegoat for future archaeologists digging through the codebase. Welcome to collective ownership, where the code is everyone's responsibility but somehow always your fault

  5. Anonymous

    - Summary: Two-panel “yelling at cat” meme. Text: “Senior Engineer: fix this code before I approve the merge / Me: that’s not even my code.” It riffs on code reviewers blocking a PR by demanding fixes to unrelated legacy code. - Why it’s funny (senior dev lens): Captures review gatekeeping, unclear ownership in monorepos, and the tension between “Boy Scout Rule” vs PR scope. Highlights coupling and process friction more than code quality. - Primary category: Code Review / Pull Requests - Secondary themes: Git/Merge, Legacy Debt, Ownership Boundaries, Scope Creep, Quality Gates, Monorepo Coupling - Suggested tags: code-review, pull-request, git, merge-approval, reviewer-gatekeeping, scope-creep, legacy-code, ownership, monorepo, process-friction - Relevance to software engineering: High

  6. Anonymous

    Pre-merge fixes: where 'not my code' rebase-s into 'my hotfix' faster than you can git blame

  7. Anonymous

    Monorepo life: Prettier rewraps a header, CODEOWNERS drags six teams into your PR, and now you're responsible for a service you learned existed from the diff

Use J and K for navigation