Skip to content
DevMeme
4049 of 7590
CodeReviews Post #4414 · source on Telegram

When you @-mention an entire org during a GitHub pull-request review

Description

Screenshot of a dark-mode GitHub pull-request comment thread. First card: user “Rohith-sreedhar…” commented “2 days ago” saying: “Perfect for gorgeous looks, can push asap @EpicGames/artv2-admin @EpicGames/developers @EpicTeamAdmin”. Reactions shown below it: thumbs-down 131, grinning face 3, eyes 2. A grey label reads “Good Looking” with hash “4e531d5”. Second card from the same user “13 hours ago” reads: “@EpicTeamAdmin Verify the pull request and merge asap” with reactions: thumbs-down 115, grinning face 6. Third card by “gak” (edited, “12 hours ago”) states: “I think you just notified 398463 members.” followed by reactions: thumbs-down 70, grinning face 54, party popper 26, rocket 22, eyes 33. Bottom left has a faint “t.me/dev_meme” watermark. The humor revolves around accidentally pinging entire GitHub teams, causing massive notification spam during code review, a classic communication mishap familiar to developers managing pull-requests and version control workflows

Comments

23
Anonymous ★ Top Pick One stray @mention and the PR went from cosmetic change to Sev0 - org-wide notification DDoS on the only resource we can’t autoscale: human attention
  1. Anonymous ★ Top Pick

    One stray @mention and the PR went from cosmetic change to Sev0 - org-wide notification DDoS on the only resource we can’t autoscale: human attention

  2. Anonymous

    Nothing says 'I'm ready for production' quite like accidentally DDoSing 400,000 developers' notification systems while trying to merge code for 'gorgeous looks.' This is why we can't have nice things like @everyone in Slack - imagine if GitHub had that feature

  3. Anonymous

    When you accidentally @mention the entire Epic Games organization in a PR comment, you don't just break the build - you break 398,463 notification badges, several Slack integrations, and any remaining goodwill with the platform team. This is the distributed systems equivalent of a reply-all email chain, except instead of annoying Karen from accounting, you've just paged every engineer, PM, and probably the CEO. The 131 thumbs-down reactions aren't just disapproval - they're a distributed consensus algorithm reaching Byzantine fault tolerance on the decision that you need better GitHub permissions training

  4. Anonymous

    Scaling pub/sub the Epic way: one @admin ping fans out to 398k subscribers, turning PR approval into a full-blown notification DDoS

  5. Anonymous

    Nothing like a ‘merge asap’ that fans out to 398,463 @mentions - a textbook layer-8 broadcast storm disguised as code review

  6. Anonymous

    Next time, use CODEOWNERS; @-mentioning 398,463 people turns ‘merge asap’ into a distributed denial-of-review - scaling only your email bill

  7. 𝙳𝚖𝚢𝚝𝚛𝚘 𝙼𝚒𝚗𝚝𝚎𝚗𝚔𝚘 4y

    zeroth

  8. @ZgGPuo8dZef58K6hxxGVj3Z2 4y

    Loool

  9. @FLIPFL0P_T 4y

    https://github.com/EpicGames/Signup/pull/24

  10. @philipp_2nd 4y

    you wont belive how much fucking spam this caused

    1. @ZgGPuo8dZef58K6hxxGVj3Z2 4y

      W t h

    2. @chupasaurus 4y

      I don't need, got'em all

  11. @chupasaurus 4y

    There were 2 other PRs with the same idea after that, but they were removed in minutes

  12. @chupasaurus 4y

    But the one in the post caused approximately 61 millions of emails

    1. Deleted Account 4y

      wonderful

    2. @anatoli26 4y

      🤔 where’s the explanation team?

      1. @chupasaurus 4y

        just below 400k members of a mentioned team in Epic's Github org times 156

        1. @anatoli26 4y

          There are 400K devs in Epic team? And they all could be notified this way? 😱 and why times 156?

          1. @RiedleroD 4y

            because there's 156 messages in that thread, and once you get tagged, you get all the notifications in a thread per mail

          2. @chupasaurus 4y

            The team is Github's term for groups inside a private org There's so many in that particular group because it's all non-Epic people who opted for an access to source code of Unreal Engine 4/5 and demos

            1. @chupasaurus 4y

              1 more thing: it was created in March 2015, 4 months before Github had added a feature preventing this whole situation to happen

  13. @anatoli26 4y

    Thanks for the explanation

  14. @chupasaurus 4y

    So it was more than 7 years until one 18 y.o. kid slammed it

Use J and K for navigation