Skip to content
DevMeme
786 of 7590
CodeReviews Post #890 · source on Telegram

The Overwhelmed Code Reviewer

Description

A meme about code reviews on large pull requests. The top text reads 'My 800 lines of code for the sprint'. Below it, 'My code reviewer:' introduces an image of the late Indian actor Amrish Puri in a white outfit, smiling and making an 'OK' hand gesture. The humor lies in the implication that a code reviewer faced with such a large amount of code for a single sprint won't actually review it thoroughly but will simply approve it to get the task done. It's a relatable scenario for developers working in agile environments where large, hard-to-review pull requests are common, leading to rubber-stamping

Comments

7
Anonymous ★ Top Pick An 800-line PR isn't a request for comments, it's a denial-of-service attack on the reviewer's attention span
  1. Anonymous ★ Top Pick

    An 800-line PR isn't a request for comments, it's a denial-of-service attack on the reviewer's attention span

  2. Anonymous

    800-line PR gets LGTM in 12 seconds - optimizing DORA lead time by forwarding all review debt to whoever’s on call at 3 a.m

  3. Anonymous

    The same reviewer who insisted we break up PRs into "digestible chunks" is now asking why the feature isn't complete yet after approving 47 micro-PRs that each added one function parameter

  4. Anonymous

    When you submit an 800-line PR at sprint's end, your reviewer transforms into a Bollywood villain plotting your demise through 47 'nit:' comments about variable naming, a request to split it into 12 separate PRs, and a casual suggestion to 'maybe add some tests while you're at it.' The real sprint velocity killer isn't technical debt - it's the psychological warfare of watching that 'Changes Requested' notification arrive at 4:58 PM on Friday

  5. Anonymous

    800 LOC PR? OK. Because at scale, the reviewer's ROI calc favors velocity over autopsy

  6. Anonymous

    800-line PR. Reviewer: “LGTM, tiny nit” - split into 12 atomic PRs, write an ADR, and make the schema change zero-downtime behind a flag

  7. Anonymous

    800-line diff, 12-second approval - congrats, you just shipped probabilistic code review with an LGTM hash

Use J and K for navigation