The Code Reviewer's Reaction to a Massive Pull Request
Description
A two-part meme with text at the top and an image below. The text on the white background says, 'My 800 lines of code for the sprint' followed by 'My code reviewer:'. The image features the character Mogambo, played by Amrish Puri, from the Bollywood movie 'Mr. India'. He has slicked-back grey hair, is wearing a white Nehru jacket with a small red rose, and has a sinister, knowing smile. He is making a perfect 'OK' gesture with his right hand. Another man in the background looks on with a worried expression. The watermark 't.me/dev_meme' is in the bottom-left corner. This meme captures the common developer experience of receiving an excessively large pull request (PR). An 800-line change is difficult to review thoroughly. The reviewer's expression is sarcastic, implying that while they are gesturing 'OK', they are either about to unleash a barrage of critical comments or give up and approve it superficially, knowing that hidden issues are likely present. It's a commentary on poor development practices and the social dynamics of code review
Comments
7Comment deleted
The reviewer's smile says 'LGTM,' but their eyes are already composing a polite email to the SRE team to expect 'unforeseen turbulence' in production
Nothing screams ‘missing the micro-PR memo’ like an 800-line diff - the reviewer’s OK sign really means ‘split it up before GitHub starts doing garbage collection on your change set.’
After 15 years of reviewing code, you realize that '800 lines added' usually means 750 lines of copied Stack Overflow, 40 lines of actual logic, and 10 lines that will survive the review - and the reviewer knows this before even opening the diff
Ah yes, the classic 800-line PR dropped at sprint's end - a code reviewer's favorite opportunity to demonstrate why 'small, incremental changes' wasn't just a suggestion in that architecture doc everyone skimmed. They're already mentally drafting the 47-comment thread about that one variable name on line 342, followed by the inevitable 'let's discuss the broader architectural implications' that spawns three follow-up meetings and a Confluence page no one will read
800 LOC PR approved in 8 seconds: either architectural perfection or the reviewer just skimmed for semicolons
Our review algorithm is O(1) regardless of diff size - 800 LOC gets instant LGTM, with the amortized cost paid on next sprint’s on-call
Reviewer’s OKR: keep PRs under 200 LOC; result - zero approvals for your 800-line sprint dump