Skip to content
DevMeme
5327 of 7590
CodeReviews Post #5844 · source on Telegram

The Duality of Pull Requests: Epic Features vs. Trivial Fixes

Description

A three-panel meme contrasting the scale of different pull requests using the 'Nick Fury and Pink Guy in Cars' format. The first panel shows a serious, black SUV labeled 'PR# 28' alongside a ridiculous, small pink car labeled 'PR# 27'. The second panel features Nick Fury from the Marvel universe, looking stern inside the black SUV, with the caption: 'Integration with 3 backend systems, performance improvements, Junits.' This represents a complex, high-effort pull request. The third panel shows the character Pink Guy grinning maniacally from the driver's seat of the pink car, with the caption: 'Added new line at the end of file.' This represents a trivial, low-effort change. The meme humorously illustrates the vast difference in substance and effort between various pull requests that go through the same development workflow, a universally relatable experience for software engineers

Comments

14
Anonymous ★ Top Pick Both pull requests get the same number of 'LGTM' comments, but only the newline fix will be blamed for breaking the production build five minutes after being merged
  1. Anonymous ★ Top Pick

    Both pull requests get the same number of 'LGTM' comments, but only the newline fix will be blamed for breaking the production build five minutes after being merged

  2. Anonymous

    Our review queue is basically a priority queue keyed by 1/LOC - so the EOF newline has logarithmic latency while the 600-line refactor times out

  3. Anonymous

    After 15 years of architecting distributed systems, I've learned that the probability of a PR getting approved is inversely proportional to its complexity - which explains why my microservices migration sits at 47 comments while Bob's whitespace fix got merged in 3 minutes

  4. Anonymous

    The real architectural decision here is whether PR#28's EOF newline will pass the linter checks that PR#27's three-service orchestration layer somehow bypassed. Bonus points if PR#27 gets 47 comments about variable naming while PR#28 triggers a 6-hour CI pipeline because someone forgot to update the integration test fixtures

  5. Anonymous

    In every enterprise repo, the newline PR outruns the three‑backend integration because our review algorithm is human: O(lines_changed) ≫ O(operational_risk)

  6. Anonymous

    Backend integration via newline: finally aligning EOF across three services without triggering the monorepo linter apocalypse

  7. Anonymous

    Our merge queue runs SRPT scheduling - shortest-remaining-diff-first - so newline PRs preempt three-system integrations every time

  8. @Araalith 2y

    Integrating with three backend systems in one PR? Give me a brick; I want to beat the crap out of that idiot.

    1. @RiedleroD 2y

      I was thinking the same lmao split up your changes into smaller PRs, mfer

    2. @EricKotato 2y

      At least it's not simply PR named "changes" with 7000 additions and 3000 deletions.

      1. @ArchangelRaphael666 2y

        that so true

      2. @Araalith 2y

        Fix

      3. @anysound 2y

        Typical “upd vendor” PR

  9. @ArchangelRaphael666 2y

    i saw so many pr with "new changes" with bunch of file modified

Use J and K for navigation