Skip to content
DevMeme
5689 of 7590
CodeReviews Post #6240 · source on Telegram

When “just open the PR” spawns a 1,228-comment review saga

Description

Meme with white background and black text at the top reading: "Just open the PR, bro! Worst thing they can do is to reject it." A smaller subtitle directly below says "The Review:" followed by a stock photo of a man in a gray polo shirt, arms defiantly crossed and face blurred for anonymity, standing in an atrium with a curved steel-and-glass ceiling. Pasted over the lower portion of the photo is a dark snippet of a GitHub-style tab that reads "Conversation 1228", implying an absurdly long pull-request discussion thread. The humor plays on senior-dev trauma: a supposedly harmless pull request snowballs into a bikeshedding marathon measured in four-digit comments, highlighting the social overhead of code reviews in large, distributed codebases

Comments

12
Anonymous ★ Top Pick The real CI gate isn’t the test suite - it’s surviving the 1,200-comment thread about tab width and method naming conventions
  1. Anonymous ★ Top Pick

    The real CI gate isn’t the test suite - it’s surviving the 1,200-comment thread about tab width and method naming conventions

  2. Anonymous

    After 15 years in the industry, I've learned that '1228 comments' on a PR isn't a code review - it's a distributed systems architecture debate disguised as a variable naming convention discussion that somehow evolved into a philosophical treatise on whether tabs or spaces better represent the human condition

  3. Anonymous

    Ah yes, the classic "just open the PR" advice - right up there with "it works on my machine" and "the deployment should be quick." When Linus himself shows up with 1,228 comments, you know you're not just getting feedback; you're getting a masterclass in why your clever optimization actually breaks on big-endian systems, violates three coding style guidelines you didn't know existed, and somehow manages to introduce a race condition in single-threaded code. At that point, 'reject' would have been the merciful option

  4. Anonymous

    Rejection is merciful; the real worst is a 1,228‑comment bikeshed that turns your two‑line fix into an ADR, a CODEOWNERS edit, and lifetime ownership of the subsystem

  5. Anonymous

    A rejected PR is O(1) pain; a 1,228-comment review is O(n^2) suffering across the org - consensus is our most expensive compute

  6. Anonymous

    Worst case isn't rejection - it's your PR spawning a 128-comment hydra where every nitpick grows two more

  7. @Hollow_Arigo 1y

    for why?

  8. @Hollow_Arigo 1y

    sorry, thought you mean SWAT-ed

    1. @Bitals 1y

      He literally was live on stream.

    2. @Bitals 1y

      https://www.tomshardware.com/software/linux/linux-dev-swatted-live-during-a-development-video-stream

  9. @Hollow_Arigo 1y

    english not my home language srr

  10. Deleted Account 1y

    Give a link

Use J and K for navigation