Skip to content
DevMeme
4318 of 7590
CodeReviews Post #4720 · source on Telegram

When "LGTM" in a GitHub review hides a hint of roulette coding

Description

Dark-mode slide with a 📖 emoji heading reading “What does "LGTM" mean?”. Under it, a sentence states: “LGTM is an acronym, frequently used when code reviews on GitHub.” A sub-heading line says “The interpretation were:” followed by four bullet points in white text: • “Looks Good To Me. (Because Google says so.)” where “Because Google says so.” appears as a blue hyperlink-styled note, • “Let's Get This Merged.”, • “Legitimate”, and • “Let's Gamble, Try Merging.” The minimalist design resembles a README or wiki page, evoking everyday pull-request banter. Technically, the image pokes fun at how reviewers rubber-stamp changes with “LGTM,” implying everything from serious approval to reckless deployment, reflecting the culture of code reviews, Git workflows, and merge anxiety

Comments

15
Anonymous ★ Top Pick LGTM: I skim-approved this on my phone - Prometheus and the 2 a.m. pager can finish the code review in production
  1. Anonymous ★ Top Pick

    LGTM: I skim-approved this on my phone - Prometheus and the 2 a.m. pager can finish the code review in production

  2. Anonymous

    After 15 years in the industry, I've learned that LGTM actually stands for 'Let's Generate Technical Mayhem' - because that PR you rubber-stamped at 4:59 PM on Friday will inevitably page you at 3 AM Sunday morning with a production incident that somehow traces back to an uncaught edge case in line 247 that everyone assumed 'looked good.'

  3. Anonymous

    LGTM: the four letters that simultaneously mean 'I thoroughly reviewed your 2,000 line PR' and 'I trust you didn't break production... probably.' Senior engineers know the real interpretation depends entirely on whether it's 4:55 PM on a Friday or if the CI pipeline is green. The 'Let's Gamble, Try Merging' variant becomes increasingly accurate as the sprint deadline approaches and the blast radius of potential bugs seems like a future-you problem

  4. Anonymous

    LGTM is our team’s lossy compression for code review - 1,200-line diff reduced to two approvals and a merge before CI times out

  5. Anonymous

    LGTM: Because in senior code reviews, 'Looks Good To Me' is code for 'Prod will reveal the architecture flaws soon enough.'

  6. Anonymous

    LGTM: CI is green, the blast radius maps to someone else’s bounded context, and the pager routes to their team - merge

  7. @Infinitelineman 4y

    I prefer "lets gamble"

  8. Max Ting 4y

    looks gay to me

    1. @nohat01 4y

      dfntly

  9. @RiedleroD 4y

    I've always read it as "looks good to merge"

  10. @sylfn 4y

    Lezhit govno, trogat mozhno [there is shit, it is allowed to touch it]

  11. @azizhakberdiev 4y

    Let's google this merely

  12. @Similacrest 4y

    Lesbian, Gay, Transgender, Merge conflict

    1. @plusdanshi69 4y

      We have a winner

  13. Deleted Account 4y

    let's go to me :)

Use J and K for navigation